Nabil Abdel-Hafeez

Results 242 comments of Nabil Abdel-Hafeez

Is there anything that speaks against this? I'd really like to have this 🙂

@sdeleuze Is there a way to configure this if I am not using WebFlux?

@djspiewak I do not want flying to mars and then realising we just want to go to the moon. So could you take a look and tell me, if I...

Still wip ;) I realised until now, you have the data model separated from the rendering logic. Would you like to keep this? Or you think my mixed approach is...

For simplification, I plan not to implement `branches-ignore` or `tags-ignore` for events that would support it. Since one can not mix it with `branches` and `tags`, but there is the...

@djspiewak I think the model should fit now, as well as the generation. I tried to go with a minimal code change approach. I also don't think this changes should...

Open questions: - `githubWorkflow` settings like the Scala version, OSs or the definition for runs-on are the same for all jobs. Should that be customisable? - Should there be more...

@djspiewak I am using this version currently in multiple projects and it works well so far. I changed to the way `oses` are compiled and added the `GenerationTarget` since I...

@catostrophe For custom workflows yes. For the default CI job aka `ci.yml` no. `push` and `pull_request` are currently still hard coded for the ci job. It is in this state,...