Nabil Abdel-Hafeez

Results 242 comments of Nabil Abdel-Hafeez

@Anshgrover23 Please stop spamming the zio projects with useless comments and PRs that fix nothing

@adamw From what I see, the issue is this line https://github.com/softwaremill/tapir/blob/5b85646a733db5d9ec4000b49d8b0687c4a54b6d/server/zio-http-server/src/main/scala/sttp/tapir/server/ziohttp/ZioHttpInterpreter.scala#L30 `Routes.singleton` is `Routes(Route.route(RoutePattern.any)(h))`. So you basically create a route that matches any method and path. You should use `Method....

@adamw My issue is, that I don't know tapir 😅 I would hope that one could just extract the method and path out of the Tapir endpoint definition. The parsed...

I think we don't need to change things in zio http, since we have transformOrFail on the codecs. Not on the segment, but on the path codec

@adamw like this? ```scala Routes( Method.GET / "a" / "b" / string("param1") / "c" / string("param2") / "d" -> handler((param1: String, param2: String, req: Request) => ZIO.succeed(Response.ok)) ) ``` Note,...

@adamw I did not try to run it, but I think this should work ```scala import zio.http._ case class Wildcard(name: String) val segments: List[Any] = List("api", "v1", "users", Wildcard("id")) val...

I am not sure about switching the focus to Scala 3. Also the retain trees was for sure needed the last time I tested it with Scala 3.3.x. If you...

@scarf005 your example has no default values. retrain trees is only for default values ```scala case class Bla(name: String = "A Default Value") ``` And there is no error, they...

@lemony312 Your direct impl returns a json for `text/plain` which you can ofc, but is not an expected behavior and therefore not the default. The default is returning a simple...