Nabil Abdel-Hafeez

Results 242 comments of Nabil Abdel-Hafeez

I took a look. It seems to me, that the code generated by the Scala 3 macro hits a limit of max identifiers for a class. If you provide me...

@andrzejressel might be true. But at the end, we can only optimize how many identifiers are generated by our macro. And I think that this is either optimal or close...

@joroKr21 good catch I was focusing on the generated layers. We can't change the signature of the existing methods, but we can add new (package private?) methods to be used...

Let me summarize: - it is probably an edge case - the current PR won't work because the pruning has to happen on combining - we could use arrays, but...

My personal opinion is, that this is a very special solution for a probably fringe use case that is also possible to have with more generic solution that already exists....

@jdegoes the purpose was to have a `Dog` decoder that fails without the discriminator. How would this work, if you don't create one explicitly?

For Scala 3 users, extension methods are very cheap and could be used. In Scala 2 I would probably add the zio as a first param list to a custom...

Auto merge can be enabled via GitHub CLI. That is actually easy and preinstalled on GH runners

I think using gh cli is preferable. If the underlying call ever changes, the CLI call would probably still look the same.

@alejandrohdezma I think it is okay to assume, that if you open GH prs you run on a machine that has the cli. But adding a little check, if it...