Hiromi Hishida
Hiromi Hishida
Hi, transferred from #639 Why not simply remove "final" keyword from GoogleAdsClient? It solves most of testing problem.
Hi, any update for this PR?? 👍
@schmittjoh Hi, I fixed your tests failing in travis. I love this Bundle and need SF4 & SF5 compatibility... So please fix travis builds by my PR and merge SF4...
Hi, it seems that "final" has come back for V16 Service Client classes in v22.1.0 unfortunately. They were not marked as final previous versions like V15. https://github.com/googleads/google-ads-php/tree/main/src/Google/Ads/GoogleAds/V16/Services/Client They do not...
Now that Laravel11 has released, this PR should be proceeded. (I'll try today :)
I tried this branch for my product along with laravel-doctrine/extensions https://github.com/laravel-doctrine/extensions/pull/66 and laravel-doctrine/migrations https://github.com/laravel-doctrine/migrations/pull/135 , it worked perfectly and all tests in my product passed successfully. No update for config...
We should fix builds first, maybe?
I almost fixed builds in #575. Only 1 phpstan failure left, but I have no idea how to fix it :( --- update: I've fixed the problem in #575 :tada:
I published example app here: https://github.com/77web/workflower-bundle-playground It's still WIP, but very close to finish! :)
I changed dependant laravel-doctrine/orm branch: https://github.com/laravel-doctrine/orm/pull/575 and fixed builds!