Holger Frohloff

Results 12 comments of Holger Frohloff

I added `, data: { turbo: false }` to all `link_to` and `form_for` helpers on the Devise views.

> Thank you for raising this issue. I had a look and I can see it's indeed a bug. Would you be able to try out this branch and see...

@seanxiesx I updated the code to move the `expire` call into the block while keeping the tests green.

I can understand that security notifications can become noisy. Then again, possibly they have to be, to be of any use?! I think the best things to improve first might...

I think we should remove ``` ruby s.add_dependency 'jquery-rails' s.add_dependency 'devise-token_authenticatable' s.add_dependency 'compass-rails' s.add_dependency 'compass' s.add_dependency 'sidekiq' s.add_dependency 'sinatra' s.add_dependency 'cancan' # we have `cancancan` now s.add_dependency 'uglifier' # is...

> Maybe this could be removed from Golden Cobra core and extracted to an individual gem. After that, this dependency would be unnecessary here. This is my goal and the...

Updating react should be done in a minor release bump, not in a bugfix release, since it might be breaking change for a project. (that's why it could even be...

Find the react components, we use. Make sure the old syntax of `React.createClass` is still supported (I know it's deprecated though).

Perhaps this can help @donni106 https://blog.discordapp.com/lessons-from-migrating-a-large-codebase-to-react-16-e60e49102aa6

I don't even know if the generator is used any more. I'll have to check.