Jeroen Wesbeek

Results 21 comments of Jeroen Wesbeek

If #4297 was merged, you could just override the renderer.

First of all, let me say that it is much appreciated that both you and @liuxuan30 spend so much time working on the charting framework (and obviously for @danielgindi for...

@liuxuan30 Thanks for your thoughts and feedback, I realize most people are contributing to this library besides their day-jobs in off-hours, so am I. I didn't _have_ to create PR...

@danielgindi @liuxuan30 @jjatie : do you have any thoughts about adding these override points for rendering logic?

@danielgindi @liuxuan30 : I updated the PR to the latest revision from `master`. Perform these three steps to the demo application in order to reproduce the example in my screenshots...

~Added a fix for #3701 that will take the axis font into account when determining the size of the labels.~ Reverted in 7e1f6a0 as it [caused the tests to fail](https://travis-ci.org/github/danielgindi/Charts/builds/749810748)...

@danielgindi @liuxuan30 @jjatie : just a quick look at open issues and PRs (see for example these ☝🏻), it looks like this PR will solve quite a number of them....

@bivant : It shouldn't really, as it is only introducing dedicated open overridable `render` methods rather than doing the rendering inline nested inside private methods. It does not add additional...