Mohamed Abd Elhady Ali issues

Repositories
Issues
Comments

Results 2 issues of


                                            Mohamed Abd Elhady Ali

Adding each potential translation vector twice.

https://github.com/Jack000/SVGnest/blob/1248dc21efd3f90d1aa52ba5785e27e5217ed2c9/util/geometryutil.js#L1567-L1579 Is there a reason each vector is being added twice? The algorithm in the NFP paper specifies that we only need to add on of these translation vectors. Could...

Simplification in _onSegment() function.

https://github.com/Jack000/SVGnest/blob/1248dc21efd3f90d1aa52ba5785e27e5217ed2c9/util/geometryutil.js#L53-L109 I think this can be replaced by a simple one liner : `return _almostEqual( _distance(A,p) + _distance(B,p) , _distance(A, B));` with `_distance(A,B)` being a function that returns the distance...