Ling Jin

icon location Chengdu icon location Keep silent

Results 317 comments of Ling Jin

cdc: add `RegionId` type to make code more clear

> I am hesitant about this PR since other components still use u64, which makes the CDC code style inconsistent with the rest. I agree to it, make the region...

cdc: add `RegionId` type to make code more clear

Close this, since we should keep code style consistency among all components. If we try to introduce `RegionId`, it should be used among all components.

cdc: remove 2.4.0 as the default kafka version keyword

/hold

cdc: remove 2.4.0 as the default kafka version keyword

After support kafka automatical detection, just remove kafka-verison keyword from the sink-uri example, to make it less confusing.

sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long

/retest

sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long

/retest

sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long

/retest

changefeed(ticdc): no need to use info and status as the changefeed tick arguments

/retest

changefeed(ticdc): no need to use info and status as the changefeed tick arguments

/test verify

changefeed(ticdc): no need to use info and status as the changefeed tick arguments

/retest