changefeed(ticdc): no need to use info and status as the changefeed tick arguments
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.
If you don't think this PR needs a release note then fill it with `None`.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from 3aceshowhand, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
/test verify
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 53.3791%. Comparing base (25676cf) to head (a2e5c78).
:warning: Report is 164 commits behind head on master.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | ∅ <ø> (∅) |
|
| dm | ∅ <ø> (∅) |
|
| engine | 69.2161% <ø> (+5.8211%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 69.2161% <ø> (+11.7252%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11629 +/- ##
================================================
- Coverage 57.4909% 53.3791% -4.1119%
================================================
Files 851 213 -638
Lines 126486 17771 -108715
================================================
- Hits 72718 9486 -63232
+ Misses 48377 7680 -40697
+ Partials 5391 605 -4786
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
/retest
/retest
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
/retest
/test dm-integration-test
/retest
/retest
@3AceShowHand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| jenkins-ticdc/verify | a2e5c78cd02c265ad5021a9a820ec09252750b68 | link | true | /test verify |
| pull-syncdiff-integration-test | a2e5c78cd02c265ad5021a9a820ec09252750b68 | link | true | /test pull-syncdiff-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.