Julian Verdurmen

Results 563 comments of Julian Verdurmen

What is the expected encoding?

Sounds good to me, but I guess it's a (semantic) breaking change?

I think also that shift_jis is better, but any proposal to change it without breaking others? (E.g. code build on shift-jis)

This is an issue: ``` if(encoder.Detected?.EncodingName == "shift-jis") { ... } ``` As it will be "shift_jis". I think this is a good idea, but because it's a semantic breaking...

As end user you could of course use .net core 3.1 etc. (Also without fork) But we will update the platform here in the future.

unclear, as the unit tests skipped the files all the time..

d17ab7282a419de7313ffb90be3debfea32653c2 also fails, ![image](https://cloud.githubusercontent.com/assets/5808377/24822374/ff8c5890-1bf4-11e7-9564-9c6e259d20ee.png)

same as 884020f7e228f80b4d10688cecac22ccebbb85ac (initial port commit)

Does anyone know the related API calls for this request?