Hanric comments

Results 30 comments of


                                            Hanric

"You forgot to add 'mini-css-extract-plugin' plugin"

Impossible to inject CSS from a node_modules import

I find the sideEffects of `[email protected]` is : ```json "sideEffects": [ "*.css" ] ``` And ths css file is `react-toastify/dist/ReactToastify.css` ,so it will be tree-shaking.

chore: support custom autoModules

the CircleCi use node v16 which cause the CI failed

bug when webpack5 modulefederation shared "vue" module

seems the same issue : https://github.com/webpack/webpack/issues/16060

fix: judge include type

@sodatea this pr can solve this problem,can you review it ?😋

fix: avoid shared module will be compiled in wrong target compiler

@ScriptedAlchemy I'm not sure whether the ProvideSharedPlugin can use thisCompilation instead of compilation, please help to review and check

fix: avoid shared module will be compiled in wrong target compiler

the webpack reproduce demo: * repo: https://github.com/2heal1/webpack-demo/tree/chore/mf-share-file * reproduce steps 1. `pnpm i` 2. `pnpm build` 3. watch the dist , and you will see two same name but different...

fix: avoid shared module will be compiled in wrong target compiler

> I'm not sure of the implications of doing this. Would it mean that any child compilers created would not include any federation stuff unless the plugin is applied again...

fix: avoid shared module will be compiled in wrong target compiler

> the webpack reproduce demo: > > * repo: https://github.com/2heal1/webpack-demo/tree/chore/mf-share-file > * reproduce steps > > 1. `pnpm i` > 2. `pnpm build` > 3. watch the dist , and...

fix: avoid shared module will be compiled in wrong target compiler

> This is caused by `addInclude` in `ProvideSharedPlugin`, all provide modules will be added to compilation (and also child compilations) at `hooks.finishMake`. > > Actually the additional html-webpack-plugin asset won't...