Yury Selivanov

Results 403 comments of Yury Selivanov

Looks like this PR is doing a right thing. @msornay please update the tests, and I will merge it.

Please reopen this PR at https://github.com/python/cpython. This repo is going to be deleted soon.

LGTM. @asvetlov can you also take a look?

I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython with a link to this PR? This would make merging this easier for me.

> Yes of course I will do it tomorrow. Would you be able to do it sooner by any chance? 3.6.1 RC1 is going to be tagged tomorrow.

> Right after the fork() in the new worker process, we raise a ForkException (a custom subclass of BaseException). This exception will bubble up to loop.run_forever(), hence unwinds the stack...

@vxgmichel As long as you do `exec` right after forking you're safe. I think multiprocessing does that, right?

I added a process pool executor test to uvloop - https://github.com/MagicStack/uvloop/commit/ad5181b36a51a0ac2ab4aaec829359711afdeda9. It doesn't crash (and it would if event loop started to execute any code after forking). Perhaps the reason...

How about we do simple ``` python import asyncio ``` at the top of each example? `get_event_loop()` should become `asyncio.get_event_loop()`. That's the style we recommend in Python documentation and use...

@denisra I wonder if we could remove `import asyncio.test_utils` completely. This is an internal module, and has nothing to do with examples (which historically were just experiments with asyncio, while...