asyncio icon indicating copy to clipboard operation
asyncio copied to clipboard

Fix stop_serving in proactor loop kill all listening servers

Open julien-duponchelle opened this issue 8 years ago • 6 comments

Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.

julien-duponchelle avatar Feb 21 '17 18:02 julien-duponchelle

LGTM. @asvetlov can you also take a look?

1st1 avatar Feb 22 '17 23:02 1st1

lgtm

asvetlov is not very active at the moment

fafhrd91 avatar Feb 22 '17 23:02 fafhrd91

I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython with a link to this PR? This would make merging this easier for me.

1st1 avatar Mar 02 '17 22:03 1st1

Yes of course I will do it tomorrow.

Le jeu. 2 mars 2017 à 23:14, Yury Selivanov [email protected] a écrit :

I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython https://github.com/python/cpython with a link to this PR? This would make merging this easier for me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/python/asyncio/pull/496#issuecomment-283799569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVFXZkNrVTmNCSK3TgLWlP-43YwozhSks5rhz8qgaJpZM4MHtGW .

julien-duponchelle avatar Mar 02 '17 22:03 julien-duponchelle

Yes of course I will do it tomorrow.

Would you be able to do it sooner by any chance? 3.6.1 RC1 is going to be tagged tomorrow.

1st1 avatar Mar 02 '17 22:03 1st1

PR opened: https://github.com/python/cpython/pull/431

julien-duponchelle avatar Mar 03 '17 15:03 julien-duponchelle