Yury Selivanov

Results 403 comments of Yury Selivanov

@fantix this seems to be outdated?

This looks good to me, let's merge?

> Technically, I understand that it's because there is such thing in a protocol. And that thing in protocol may make sense for scripts or something Yes > but it...

> @1st1 let's consider alternative names for the "statement" and the "script" methods, because I've seen similar confusion from asyncpg users. Some links from my slack conversation with @elprans: *...

I started to write a big comment in `edb/server/edgecon.pyx` to explain why we compile one EdgeDB `SimpleQuery` message to one PostgreSQL `SimpleQuery` message only to see that it's no longer...

> I mean. I'm okay if we rename execute -> execute_script or execute_batch or alike (and leave everything as is) No, we rename nothing now. Later we add a new...

Latest thoughts on this: - [x] Rename `Connection.fetchone()` to `Connection.queryone()` - [x] Rename `Connection.fetchall()` to `Connection.query()` - [ ] When we fix https://github.com/edgedb/edgedb/issues/1107#issuecomment-597294767 we can add support for arguments to...

> Thus, I think it would be worthwhile to briefly mention in the docs for Connection.execute() as a note at the bottom that if the results are desired, queryone() or...

#### I'll keep the issue open until execute() gets support for `*args` and `**kwargs`