Yury Selivanov

Results 403 comments of Yury Selivanov

Hm, I'm not sure why we need this. The proposed global state client API works at the client connection level, not at the qb level: ``` session = client.withGlobals({user_id: my_user_id})...

> That's why I asked this ☝️ Got it :) Yeah, I was mostly talking about `e.set()` -- don't think we need it that much. > But we still need...

I like the proposal. +1 Few comments: > npx edgeql-js --generator queries: generates just queries > In this case npx edgeql-js --generator qb would generate the query builder and just...

> Oops, meant to clarify this. I think we should flatten all the queries to one level and throw an informative error if there's a naming conflict. Hm, this would...

> How do other database drivers handle this? Yeah, good question.

I'm -1 on depending on decimal.js directly. It can be an optional dependancy and we can have some API to DI it, a la `client = client.withDecimalJS()`.

Maybe. We are working on getting https://github.com/edgedb/rfcs/blob/master/text/1000-migrations.rst implemented as soon as possible. Migrations can be quite complicated so they necessitate an interactive process. So far we don't have a good...

@elprans @fmoor I think we should pause and re-evaluate if we can just use standard Python `tuple` instead of a custom `edgedb.Tuple`. We'll still have to have `edgedb.NamedTuple` fwiw, but...

> I had never worked on a C extension before so I was starting small. NP, but since this is now done and looks good, I suggest to generalize the...

Closing this one -- we got rid of edgedb.Tuple