Aurelia Molzer
Aurelia Molzer
"making some assumptions" of the equivalence of these two operations is the confusing part (and this comment is the first I see that assumption spelled out as such precisely). Quite...
Never mind the AcqRel, it's admittedly a stupid solution that shouldn't be necessary and I've omitted the details on purpose. (Though: edited in above, discuss in another thread if you...
The responsibility of the implementation of the check seems to me like it should belong in our code. Similar to the standard library having added checked variants of `split` even...
As already remarked. Same as async, if someone can present a coherent design to protect invariants and implementation flexibility (including code reuse) then sure, but otherwise this is more maintenance...
Since https://github.com/image-rs/image/pull/2239 is breaking on the `Pixel` trait but otherwise the surface is quite small, would be great to decide on it, and imo land, it in `0.26`.
Pending PR demonstrating benefits, I don't see reasons to switch to `rgb` other than `1.0` (if ever). We have decent compatibility between the crates for passing reference data that does...
> Why expect Container to Deref rather than Deref which is more strongly typed? > > Why use a generic Container rather than using Vec when Deref is a required...
The attempt at this was: https://github.com/image-rs/image/pull/2478 but the sentiment was that we should _first_ do the more general buffer and then rename rather than churn with no good replacement path...
Re-reading this, I think the initial question has been largely addressed. Inline with the suggestion that most metadata does _not_ influence color process, https://github.com/image-rs/image/issues/2262#issuecomment-2183385821, we've only added CICP color space...
Neat, this looks interesting. I'll have a closer look later. On a general note, the `std` feature seems unnecessary and I'd rather the `alloc_impls` module be a separate file.