Ionut Cioflan comments

Repositories
Issues
Comments

Results 4 comments of


Ionut Cioflan

Newlines after //@cc_on comments are removed

Uncaught Error: Firebase\JWT\JWT::decode(): Argument #3 ($headers) cannot be passed by reference

Currently the release 2.1.1 has the following dependency "php": "^7.1|^8.0", https://github.com/TheNetworg/oauth2-azure/blob/v2.1.1/composer.json My suggestion is to drop entirely firebase/php-jwt": "~3.0||~4.0||~5.0" and only keep compatibility with ^6.0 because older version are not...

Uncaught Error: Firebase\JWT\JWT::decode(): Argument #3 ($headers) cannot be passed by reference

I have createa a pull request, that 3rd argument is not necessary anymore, the variable $keys already is converted to ann array of `\Firebase\JWT\Key` https://github.com/TheNetworg/oauth2-azure/pull/189

Uncaught Error: Firebase\JWT\JWT::decode(): Argument #3 ($headers) cannot be passed by reference

I was also suggesting dropping the compatibility, because that may have been the reason for using the 3rd argument.