Soumik Majumder
Soumik Majumder
I am marking this issue as "helping with an issue" for the time being. Mainly because it seems like there is a lot in your environment that we are not...
Code looks good to me, gonna take a closer look at the new test!
I believe it was just "getting the word out" Not sure if that still is the case
> Hmm, maybe, but I am not sure why someone would want to turn it off. One case I can think of is pipelines. They would probably want to error...
The changes themselves LGTM 🤔 Re: Error structuring I think we are: - Retaining how we used to show errors for one error by using the `len(unsuccessfulChanges) == 1` check...
So I am guessing multiple errors will be unformatted 🤔 Also, I m not entirely sure if the way we format a single message will help in case of multiple...
I think I am satisfied with how the UI changes look as well, I cannot think of how we can make a list of errors look better right away. But...
Also, @praveenrewar looks like this branch needs a rebase. I will take one final look at this once it is done!
This issue is motivated by the fact that app-change config maps might be larger after resolution of #338
Thanks for the draft PR @redbaron ! Will definitely go through the changes to get an idea of what's going on.