Gyanendra Banjare comments

Results 12 comments of


                                            Gyanendra Banjare

[WIP] Unify AST::ExternalFunctionItem with AST::Function

Wanted to do that, but will it be a good practice? Also it generates ambiguous functions, that can be probably tackled with virtual and override.

[WIP] Unify AST::ExternalFunctionItem with AST::Function

Yes, will try out some things and see if it works.

[WIP] Unify AST::ExternalFunctionItem with AST::Function

Yes overriding works, now I have to make corresponding modifications in `Rust::HIR::ASTLoweringExternItem`.

[WIP] Unify AST::ExternalFunctionItem with AST::Function

I am getting an unexpected bug. Where should I start looking? It is working fine for functions, and external-functions with no parameters. ```rust extern "C"{ fn fun(a:i32); } ``` test.rs:2:25:...

[WIP] Unify AST::ExternalFunctionItem with AST::Function

```rust extern "C"{ fn fun()->i32; } ``` has the same error. So probably external function items are not being resolved

[WIP] Unify AST::ExternalFunctionItem with AST::Function

Requested changes made and removed `AST::ExternalFunctionItem` dead code.

[WIP] Unify AST::ExternalFunctionItem with AST::Function

> Looks good. You might want to split off some of these commits into separate pull requests, so that they can get reviewed/merged faster -- that's what I tend to...

[WIP] Unify AST::ExternalFunctionItem with AST::Function

Rebased, now it should be able to merge

Tuple pattern as function parameter causes internal compiler error

Trying out different irrefutable patterns as parameters, will comment if any other pattern causes error.

Tuple pattern as function parameter causes internal compiler error

While investigating this bug, I tried out this: https://godbolt.org/z/3s398sW1r The below code compiles correctly. ```rust fn myfun() -> i32 { let (x, a) = (1, 2); x } ``` This...