0xmikko.eth

Results 8 issues of 0xmikko.eth

As I mentioned in https://github.com/bluzelle/blzjs/issues/34, there is a problem in reading all key-value pairs from DB. As possible solution it could stream reading (like ReadableStream) or getting values by sending...

I have a DB (UUID: 26542be2-b69f-4177-96a8-f97818a3b37f) which contains BlizelleHQ tweets. When I invoke keyValues() function it returns 110 KV pairs, however db has 510 ones. It seems that the problem...

Working on hackahon project I profiled your testnet library in case of performance. It takes 3500-5500 ms for writing operation for the moment. From my opinion it depends on blockchain...

# Problem In current design, before any operation, creditManager checks allowance needed. To do that, it calls [`_provideCreditAccountAllowance`](https://github.com/Gearbox-protocol/gearbox-contracts/blob/372a8a912629c15843f02b5b82bbf51baabf4bfb/contracts/credit/CreditManager.sol#L862): ``` /// @dev Checks that credit account has enough allowance for operation...

bug

# Problem CreditFilter.sol has a two functions which allow / forbid tokens in allowedTokenList. When DAO forbids token, it set a mapping value for such address to false: ``` ///...

bug

Current implementation doesn't take into account how much tokens were sent to pool back, which is okay for current underlying tokens. However, if someone will decide a pool with fee...

suggestion

**Problem:** Current design requires 2 different contracts for pools: diesel token & pool itself. It's not optimal for gas consumption and do not support modern standards like 4626 **Solution:** Combine...

suggestion

At the moment, credit manager provides liquidation premium = totalValue * liquidationPremium. For some cases, if account has very valkid assets with low LT (for example 25%), such account could...

suggestion