Ahmed Gouda
Ahmed Gouda
can i pick this up?
@alexey-milovidov, Picking this up!
@alexey-milovidov I tried counting the entire input dataset to calculate the fractions then using `input.reopen()` to reinitalize the underlying input ports, but it doesn't seem thats how the pipeline implementation...
@nihalzp Thanks, that helped a lot, I got the feature working.
@alexey-milovidov, 1. Do we only need to support single-digit fractions [0.1, 0.2, ..., 0.9], or 2-digit fractions [0.99, 0.75, etc.], are also required? 2. Also, for big row numbers it...
> Could it be arbitrary fraction?, ie AFAIK parser should just support like float64 for parsing of decimals. @UnamedRus Actually, I am currently using `DataTypeDecimal32(2, 1)` for parsing the number...
@UnamedRus - It's a normal limit with fractions representing percentages, like mentioned in the issue description. - Will take a look at the SAMPLE code you mentioned, thanks.
> My concern with this approach, that LIMIT 1 have meaning as get 1 row (which is right now), and also have meaning if someone generate query programmatically with fractional...
@JelteF It's been about 3 months since I opened this. Can I have a review when convenient? Actually, the failing test after i rebased is because SQLSmith detected a crash:...
Hi @alexey-milovidov , I'd like to work on "Negative and fractional LIMIT values".