alpharush

What command did you run and what's the issue (it's not clear to me what result you're saying is a false positive)?

Yeah, I think you could check if the post dominator node is a return and drops those from the results https://github.com/crytic/slither/blob/ce9dbf650d7acfee51ddafd844929f4e8d345672/slither/detectors/statements/costly_operations_in_loop.py#L39 Would you like to work on this issue @plotchy...

I cannot replicate this and call is considered in the detector https://github.com/crytic/slither/blob/e3b75c003eccbacd5577278dfe2c92752a187b94/slither/detectors/attributes/locked_ether.py#L60 Output from slither 0.8.2 on the example: ``` WithdrawMock.withdraw(address,uint256) (test.sol#9-12) sends eth to arbitrary user Dangerous calls: -...

I think we should also consider adding mypy for a subset of the project, at the very least. Namely, the following directories: `core/`, `detectors/`, `slithir/`. There were a couple bugs...

Would you be able to share a reproducible example?

At first glance, it looks like maybe there's some sort of conflict in the compilation artifacts between the IERC165's defined in aave-v3 and forge-std as the function that's being parsed...

Maybe related to https://github.com/crytic/crytic-compile/issues/285 h/t @plotchy

@mds1 The top level key "id" of `~/flexible-voting/out/BridgeLogic.sol/BridgeLogic.json` and `~/flexible-voting/out/IERC165.sol/IERC165.json` are the same so it causes issues when slither resolves the [source mapping ](https://docs.soliditylang.org/en/v0.8.17/internals/source_mappings.html) here: https://github.com/crytic/slither/blob/a41f86739d9d2aad7596b9a0ac0ab2ce644fc2f3/slither/core/source_mapping/source_mapping.py#L133-L150 The use of a...

Please see https://github.com/crytic/slither/issues/1031#issuecomment-1138037731

I would start with the lowest hanging fruit and see if the return value is always one argument (no branches) and a literal, but this is a good idea long...