0xPIT comments

Results 7 comments of


                                            0xPIT

Fix race condition causing lost events

can you please clean up the PR so that I can review the actual changes? You did a lot of formatting changes, please undo them as well.

Fix race condition causing lost events

Thanks a lot, I'll try to review this on the weekend!

Fix race condition causing lost events

I've manage to review most changes last night. Thanks for your contributions. I won't merge one big PR, though, but I'd like to integrate most of your changes. Would you...

Relay: Partial Pulse Time based on fauxESP brightness value (Alexa, blinds 50%)

Thinking of it, the key question seems to be do we need to keep state or not and who keeps state? With the example of blinds, opening (moving it up)...

menu items not all visible

can you post your code?

Using constants during MenuItem creation

The macro `MenuItem` instructs the compiler to put the whole structure with the label string into progmem, see [here](https://github.com/0xPIT/menu/blob/master/Menu.h#L80), so you can not pass a string already in progmem to...

5.1->5.2 introduces undefined MSPI_TIMING_FLASH_DEFAULT_CONFIG_ID_CORE_CLK_240M_MODULE_CLK_80M_STR_MODE in mspi_timing_tuning_configs.h (IDFGH-13286)

Thanks, I understand how it can be fixed, this error, normally stems from different SPI speeds configured for PSRAM and flash. The error I tried to report here is that...