Eric Woolsey
Eric Woolsey
I just updated. BTW in the above queries I omitted `AND kind = '...'` for simplicity, but that's why you see it in the query plan.
> Technically we could implement a special query plan for it, but it's not done and currently not planned This would be amazing, and I think would benefit a lot...
Anyone here have any idea?
> Could you clarify the issue? Ah yeah sorry if I wasn't clean. I'll give a concrete example. So none of the versions line up between `astroport-pair` and `astro-port`. ```rust...
@emhane thanks so much for taking a look. I'm not 100% sure what you're suggesting though. Are you saying to remove `type Consensus` from `PoolTransaction` entirely? Or are you suggesting...
@emhane @mattsse Thanks again for taking the time to review. > I think ideally we replace the EthPool restrictions to something like alloy::Transaction or similar Sounds good to me. Assuming...
Quick update, @mattsse I took a look at alloy::consensus::Transaction but I don't think that quite solves the problem we have, perhaps I'm not quite understanding your suggestion. Anyhow, going to...
@emhane @mattsse So after trying to apply these trait bounds directly to the methods for a couple hours I've found that it just kind of explodes. You end up with...
@emhane @mattsse I've implemented the changes you've suggested! Specifically I've: - Removed the bound on `IntoRecoveredTransaction` - Renamed `IntoRecoveredTransaction` to `ToRecoveredTransaction` - Switched to using `where` clause - Merged from...