Eric Woolsey

Results 136 comments of Eric Woolsey

closes #603 No breaking changes in this PR, should be fully backward compatible.

@epage or @matthiasbeyer any chance I could get one of you to take a look?

@epage sounds good to me. I needed this change on my personal fork anyhow. I posted an issue [here](https://github.com/rust-cli/config-rs/issues/603) a couple weeks ago. Happy to discuss any design changes you'd...

Any update on this effort? I would really like something `like #[instrument(fields(response_code = ret.response_code)]`. There really isn't a good workaround for this other than creating an entirely new function. that...

@barafael any updates on the status of that fork? It would be really useful for me!

@xosxos just loaded up your fork and it seems to be working well enough! Hard to say for me as my app doesn't seem to really work with klask in...

> now everything that doesn't want to be maybe has to be explicitly marked. This isn't how I was envisioning it. You wouldn't have to declare non-async functions as the...

Anyone have any thoughts on this? Would be willing to take a stab at implementing if there's demand.

> What's generating the type URLs? I'm assuming they're just being scraped from the .proto files. Likely whatever template they're using to generate the code includes those extra derives

Ah yes I see that would be pretty convenient. Perhaps you can comment more on this, but I've wondered why cosmrs redefines many of the types in cosmos-idk-proto. Adding these...