Luo Bo

Results 7 comments of Luo Bo

@TartanLlama Would you mind taking a look at this PR?

I usually import flare as a submodule and symlink `proj_root/flare` to `proj_root/path/to/flare-submodule/flare`. `BLADE_ROOT` / `thirdparty` can be provided either with a different (but compatible) version, or symlink to corresponding file...

LFS bandwidth quota for our GitHub account has been reached. I just got notified about the situation several hours ago. All repositories with LFS enabled under Tencent are suffering from...

The issue w.r.t. LFS bandwidth quota has been fixed.

Well it’s symlinked that way just for convenience, you don’t have to symlink that way (nor use the same version). So long as a API-compatible version of each dependencies can...

确实写错了,感谢反馈,我处理下。 本意是避免多个fiber同时调用用户的callback,不然容易导致线程安全问题。因为一般除非极端情况下timer运行的特别慢,不然不会导致多个timer同时跑,所以对用户来说大多数情况下在timer里面加锁也没太大意义。 UserCallback的另外一个目的是为了在下面套上shared_ptr,提供CopyConstructible,不然没法多次StartFiberDetached。(不过单纯就这一点来说其实`shared_ptr`也是一样的)

本来的想法是采取一个[跟Windows类似的做法](https://devblogs.microsoft.com/oldnewthing/20150928-00/?p=91501),避免因为timer处理不过来导致一直在跑个不停 不过现在想想这个做法可能确实容易给用户一些非预期的结果,而且很难定位到问题出在这里,可能确实while (remining--)更合适些