Alessandro Cheli
Alessandro Cheli
That would be interesting! Yeah. I am lately quite busy and don't have much time to spend behind metatheory.jl, but I can take a look at the PR. Please, if...
I think it's generally a good idea, but we don't definitely want to define `isvariable(x::Symbol) = true`, because in `Expr` we won't know when a symbol is used as a...
In Metatheory.jl I'm having ``` # TODO: document Base.@inline maybe_quote_operation(x::Union{Function,DataType}) = nameof(x) Base.@inline maybe_quote_operation(x::Symbol) = x ```
Have to adjust docs
> Term manipulation could change `symtype`. If we don't want `maketerm` to take `symtype`, we should call `promote_symtype` but that's a dynamic dispatch and expensive. Should we make `symtype` a...
> > Term manipulation could change `symtype`. If we don't want `maketerm` to take `symtype`, we should call `promote_symtype` but that's a dynamic dispatch and expensive. Should we make `symtype`...
> > > Term manipulation could change `symtype`. If we don't want `maketerm` to take `symtype`, we should call `promote_symtype` but that's a dynamic dispatch and expensive. Should we make...
@bowenszhu can we please also add the changes for sorted/unsorted arguments from #615 here? I didn't change many callsites of `arguments`, just low-hanging fruit like `node_count`. This is blocking my...
@ChrisRackauckas will break downstream in the same way #615 does. I think it really makes sense to update downstream a single time, otherwise we will need to have 6 PRs...
> The implementation detail of make_term has nothing to do with TermInterface. Just call promote_symtype there to be correct, otherwise, this PR is not acceptable. @YingboMa will do. Wanted to...