Alessandro Cheli

Results 180 comments of Alessandro Cheli

> @0x0f0f0f if you agree, I'm going to close this PR and open a new PR and branch that only contains the changes for the schedulers and should be easier...

Added support for it in #185 - the function must be defined though

Checked yesterday night. This is now supported. ```julia julia> r = @rule Main.identity(~a) --> ~a Main.identity(~a) --> ~a julia> r(:($(identity)(a))) :a julia> r(:(identity(a))) julia> r(:(Main.identity(a))) :a julia> module Foo identity(x)...

Can you please move `MetadataAnalysis` to `src/`? Can you make the types stricter via a type parameter?

> > Can you please move MetadataAnalysis to src/? > > IIUC, this would force users to commit type piracy by defining their custom `EGraphs.join` on arguments of type `Metatheory.MetadataAnalysis`?...

> But that would probably require handling the predicate in the compiled matching function. Yes indeed

@gkronber This suggests that we probably need a nicer way to attaching predicates to variables. Probably a per-scope dictionary in patterns: When parsing pattern ``` a / a::is_nonzero ``` The...

Nice, thanks a lot! Can we keep the old `prove` interface by renaming the function that returns also the egraph to something like `saturate_prove`, then have `prove` to check if...

> > Can we keep the old `prove` interface by renaming the function that returns also the egraph to something like `saturate_prove`, then have `prove` to check if the condition...