Drew Greene comments

Results 5 comments of


                                            Drew Greene

Extend validation schema for function properties

@amimas All the extended schema I think are good to add but I scoped this PR just to the function properties because I happened to be testing them. If you...

Feature request: a hotkey to open the playing GIF on a page to the scrubber.

I'd need more information to describe this. How would it work if there are multiple GIFs on the page, etc?

Feature request: a hotkey to open the playing GIF on a page to the scrubber.

Unfortunately there is no real control over the state of the GIF other than where it has loaded or not. You could theoretically determine if a _single_ image was scrolled...

Firefox: "Not a valid GIF file"

Could you verify in your extension settings if the permission has to access data from all sites? I noticed just now that on a new install it was turned off...

fix: match day counting behavior with Day.js in English locale

Not sure if it was the intent to entirely match with Day.js behavior, but when I compared the existing tests with Day.js, I found about 14 that didn't align with...