Maksim Kovalev

Results 16 comments of Maksim Kovalev

I suppose that's an attempt to implement Double-check locking pattern in idiomatic Kotlin-style way. Unfortunately, it's implemented incorrectly since the first null check should be done outside of `synchronized` block...

Actually, it's possible to make it work correctly: ```kotlin fun provideTasksRepository(context: Context): TasksRepository { return tasksRepository ?: synchronized(this) { tasksRepository ?: createTasksRepository(context) } } ``` I wouldn't say this improves...

For me, resolving the jdk classes issue required some additional changes in the above snippet. I had to access `jacoco.excludes` inside of the closure using explicitly specified `it.`. Otherwise the...

BTW, if you're a MacOS user you can install it with Homebrew: ``` brew install bundletool ```

@Rolf-Smit > I also want to get rid of reusing the testCoverageEnabled property does it mean the property is used only as a configuration flag and brings no other benefits?

Check if you have any other plugin instrumenting your classes. We had the same issue and the reason was [Firebase Performance plugin](https://firebase.google.com/docs/perf-mon/get-started-android#add-perfmon-plugin) instrumenting classes which breaks Jacoco instrumentation. The fix...

This repo seems to be abandoned. We recently migrated to https://github.com/NeoTech-Software/Android-Root-Coverage-Plugin which supports AGP 7.2 and has some cool features simplifying its configuration.

That worked for me except I cannot paste credentials using the system autofilling feature. The app could be a bridge between the PWA and the autofill framework. https://developer.android.com/guide/topics/text/autofill https://developer.apple.com/documentation/security/password_autofill/

The issue is still there, though AS is now able to display the merged manifest even if there are errors.

@ArtemBatkov > I added a key to the local.propery file but my manifest has no idea what is the "MAP_API_KEY" and it throws errors when building. What I am doing...