0neGal
0neGal
> I'm not sure if pinging a good domain is the best course of action, since being able to connect to e.g. `northstar.tf` doesn't tell us if we can connect...
> since I'm already working on extending this, should there be anything else added? I was thinking it'd make sense to have a function like `requests.check_connection(url/domain)` or similar (name not...
> agreed, lets clarify how this function should behave I don't think just pinging or checking if a host is available is a good idea since many ISPs fake that...
As it stands, I'm not sure I'd agree that this fixes those issues, but were you to add something like "this may happens due to file permissions" or similar, it'd...
> sure, but this should be done regardless. > this is just a blanket solution that gracefully deals with _all_ errors during unzipping Totally agree > actually checking if we...
I figured Windows did some dumb stuff underneath or handled something different oh well, any fix is appreciated really... Whether it's recursively checking the files inside, or creating a file...
The original intention was that the dialog would show, and it'd disable the buttons beside the gamepath related ones, letting you mount the drive or fix permissions etc without having...
I see, I suppose you could do: ```js ipcMain.on("gamepath-lost-perms", async (e, selected_gamepath) => { if (! gamepath.setting && ! gamepath.lost_perms == selected_gamepath) { gamepath.lost_perms = selected_gamepath; // remaining code ......
Besides localization, this should be able to be merged.
Just as a refresher, was the only thing missing in this PR the Spanish localizations? If so, I intend to make an issue dedicated to fixing that later on, and...