Brandon Frohs

Add support for class_alias()

8

[`class_alias()`](https://secure.php.net/manual/en/function.class-alias.php) doesn't seem to be taken into account with manually specified definitions (possibly broken elsewhere as well). ``` php class Test {} class_alias('Test', 'TestAlias'); $builder = new DI\ContainerBuilder(); $builder->useAutowiring(false); $builder->addDefinitions([...

`ServerRequestFactory::fromGlobals()` checks if args are truthy rather than set

3

In `ServerRequestFactory::fromGlobals()`, most of the code checks if the arguments are truthy, rather than set. For example: https://github.com/zendframework/zend-diactoros/blob/89d471cc09850c7d47839cf16ba7a1fed54d45e5/src/ServerRequestFactory.php#L57-L58 https://github.com/zendframework/zend-diactoros/blob/89d471cc09850c7d47839cf16ba7a1fed54d45e5/src/ServerRequestFactory.php#L72-L74 This becomes an issue during testing (or a long-running process that...

Add $insertions_count and $deletions_count.

1

Add counter to keep track of the number of insertions and deletions. Replacements are considered 1 insertion and 1 deletion. # Example ``` php

Currently, it takes a bit of digging to find the correct functions to use, and the following code causes an error: ``` ``` However, adding the magic `__toString()` method makes...

`fopen($path, 'x')` should not succeed when called twice

3

The `x` mode for `fopen()` should fail when called twice, as the first call should create the file. ```php $a = fopen('fs://test.flag', 'x'); $b = fopen('fs://test.flag', 'x'); if (is_resource($a)) {...

Make methods strongly typed instead of using string input parameters

13

***This is ready to merge, pending any review from you. (Change log may need updated depending on timing of next release.)*** ### Description PHPWord uses a mixture of strings (constants...

`reset_middleware()` doesn't prevent middleware from running for route

2

[`reset_middleware()`](https://docs.rs/tide/0.16.0/tide/struct.Route.html#method.reset_middleware) doesn't affect which middleware is ran for a route. With the following code, I'd expect a 200 response with the text "Success!". Instead, the log shows: > thread 'async-std/runtime'...

Version changing between POSTs results in loss of POST data

8

## Reproducing results 1. Load a multi-step form 2. Submit to go on to the second step 3. Change `version` sent in response header 4. Submit to go on to...

Send version request header

1

In order to avoid wasting server resources, I'd like to be able to check the `version` already registered for PJAX before processing anything, in order to end the request early,...

[polyfill] Add ability to use Promises for core node functions

2

Something like: ``` var readFile = Promise.nodeConvert(fs.readFile); return readFile("foo.txt", "utf-8"); ``` Q Docs: https://github.com/kriskowal/q#adapting-node Q Code: https://github.com/kriskowal/q/blob/master/q.js#L1655-L1693