Brandon Frohs

Results 32 comments of Brandon Frohs

This request was made in order to fix the issue mentioned in #358.

We've implemented this fix on our production site and it works wonderfully. Basically: 1. PJAX sends the version in the request ``` javascript /* ... */ xhr.setRequestHeader('X-PJAX', 'true') xhr.setRequestHeader('X-PJAX-Version', currentVersion)...

And, really, you could just send the `X-PJAX-Version` header and let the user handle the `pjax:error` listener. (Maybe throw an example in the docs?)

> Thanks for the detailed explanation. I might have to think about this for a while. But I think it makes sense that it can be useful to send the...

> We already have a solution for that, and that is server setting the `` tag on the initial page load with layout and subsequently responding with `X-PJAX-VERSION` header to...

I use pinned tabs as applications that I regularly access and need notifications for (eg, Inbox, GitHub, etc). So I don't need (or want) to see the page title, url,...

> @0b10011: What would happen when the sidebar shrank down to its condensed height? When the collapsing feature is turned off, it would appear as-is all the time. When it...

> If there were multiple lines of pinned tabs, the pin could either be repeated for each one, or centered vertically. Or maybe another icon-less solution (bg-color for example). Alternatively,...

> So you wouldn't know which tabs you had pinned They could be listed on their own lines as well. Which defeats the purpose of saving space, but they could...