Brandon Frohs

Results 32 comments of Brandon Frohs

Merging #1661 broke this. I'll get a fixed version up tomorrow. (Tried using GitHub's in-browser conflict resolution, but it resulted in an empty commit.)

Rebased, fixed, and squashed. All checks passing.

> @0b10011 Impressive work. Thanks! I didn't quite realize how large the change was going to be until I was already well into it, but I'm pretty happy with how...

> This looks like a super interesting thing PR. Would you be willing to rebase on develop ? I unfortunately have covid right, and it's got me pretty worn down....

I'm a big fan of liberally adding newlines (in place of semicolons). I'm currently using babel+babili in a separate repo to build a minified script that's directly imported into my...

> It would help from a diff-readability standpoint, just not the on-disk filesize. Yes, this is what I mean. Both the diff, and the amount of data committed. By rewriting...

I think I have a fix for this (see reference above), but afaict, it was an issue with image dimensions not being read from the `style` attribute in HTML documents...

It looks like this is specifically due to adding the middleware to `Server` instead of `Route`. Here's a test for this issue: ```rust #[async_std::test] async fn app_middleware_reset() -> tide::Result {...

I have a fix for this (see previous references), but waiting on #1669 to be merged so I can get it in. (May be a bit; it's a large PR...