Jasjeet Singh
Jasjeet Singh
> Feed and Listens are both good options for landing pages imo. Hoping to Revive this pr and voting for listens to be the homepage for logged in users
> Off-topic, however I am _not_ looking for support or an answer and not willing to install/register on another website simply to tell you this: the app is currently outdated...
@antonis Pr is ready for review!
Note: Component left in PR for easy review: `NotificationsSettingsDialogPreference` which should be removed before this PR is merged.
> I was wondering if the commits can be split into smaller PRs that can be reviewed and tested independently? If there are dependencies the PRs can be chained and...
> ### Checkstyle > ``` > [ant:checkstyle] [ERROR] WordPress/src/main/java/org/wordpress/android/ui/prefs/notifications/NotificationsSettingsMySitesFragment.kt:85: Specific imports should be used for FluxC Store inner classes [RegexpSingleline] > [ant:checkstyle] [ERROR] WordPress/src/main/java/org/wordpress/android/ui/prefs/notifications/NotificationsSettingsMySitesFragment.kt:95: Specific imports should be used for...
> Hey @07jasjeet 👋 > > thank you for the submitted fixes. All the checkstyle issues have been resolved and most of the Detekt issue. > > The following Detekt...
> Taking a step back I think that we should return in our plan to split the code into multiple PRs that can be reviewed and tested individually. Do we...
Hi! can I pick this one up?