George Zhao

Results 15 comments of George Zhao

I can also reproduce the memory leak with longStackTraces enabled. ```javascript // npm install bluebird faker memwatch-next var Promise = require('bluebird'); Promise.config({ longStackTraces: true }); var faker = require('faker'); var...

Do you mind use the solution here so that it doesn't need an extra dependency? https://github.com/newrelic/node-newrelic/blob/0113eb5f0e707dc662a17d262a841503bab88841/lib/instrumentation/core/http.js#L214 ``` 'res-headers': (res.getHeaders && res.getHeaders()) || res._headers, ```

@JasonShin could you help review this PR? including grammar issues lol

@JasonShin looks like ReadOnly is an easy fix but I am not sure whether this is a breaking change. I'll put them in 2 separate PRs. https://github.com/zorji/type-fest/pull/1/files

@JasonShin actually I think I found a way

> Could this use the trick mentioned in https://github.com/sindresorhus/type-fest/issues/118#issuecomment-657259814 ? @sindresorhus I have tested and found the suggested implementation doesn't work for union of array

Hi @stephenh do you have an example that you need to differentiate `Exact` and `ExactDeep`? I was trying to implement an `ExactDeep` implementation in https://github.com/sindresorhus/type-fest/pull/259 But this type `Exact` is...

Hi @JasonShin I tried to find a solution but I couldn't make it work. However, after some thought about it, I feel there is something wrong. An intersection type of...

I also found the `|` operator could be confusing too For the follow type ``` type MyList = Array | Array ``` I am not sure whether I should interpret...

Hi @JasonShin I attempted 2 approach to extract a node from an array and it seems they gives me different result. ```typescript type ArrayAnd = Array & Array type ArrayNode1...