Zac Bergquist

Results 236 comments of Zac Bergquist

> Actually, there's also icon.bmp there, I will update it too. Oh yeah, we do need a new icon for that, but it needs to be gray and white like...

I imagine we will backport this to 14 and 15 as well, with the same caveat - don't merge backports until we're ready to release 16.1.

> Figured I'd give it a quick try and you're right it's much easier to digest what's going on. Added it into the PR. It does indeed look a lot...

Also worth fixing - We have two versions of `ttlmap` in use by the codebase: `mailgun/ttlmap` and `gravitational/ttlmap` - We use the clockwork package to fake clocks 90% of the...

@webvictim that's because `tsh version` wants to detect your server version as well. `time tsh version --client` should be much quicker.

Quick audit: - github.com/gizak/termui/v3 is only used by `tctl top` - do any of the charm libraries work instead? - github.com/HdrHistogram/hdrhistogram-go is only used by lib/benchmark - Plugins use github.com/go-resty/resty/v2...

I would love to remove cloudflare/cfssl from gravitational/license: https://github.com/gravitational/license/issues/12

@nklaassen can login rules be used to work around this?

Ah, right. So we'd have to make some updates to fetch the full set of group memberships in a separate request. At that point, you might still need login rules...

Microsoft also provides some other [suggestions](https://learn.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-fed-group-claims#important-caveats-for-this-functionality): - Add only the groups [assigned to the application](https://learn.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-fed-group-claims#add-group-claims-to-tokens-for-saml-applications-using-sso-configuration) - Configure a [group filter](https://learn.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-fed-group-claims#group-filtering) to get the number of groups down under the limit