Tobias Zulauf comments

Results 82 comments of


                                            Tobias Zulauf

[5.2] Mail Templates language file loading not using the MailsHelper::loadTranslationFiles

Thanks 👍

[5.2] Add the "none-ID" behavior to the CRON Scheduler

> The deprecated message as the same issue, it's triggered on every request if the home page menu has an ID. Hmm yes will remove the call for now. Or...

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Works good to me thanks @Hackwar still i would recommend to apply this PR + move from id= to taskid to be sure which ID is passed over. So this...

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Adding back the deprecated message as that issue will be fixed by https://github.com/joomla/joomla-cms/pull/43164 > To be honest, I'm hesitant to merge this if it isn't necessary anymore due to https://github.com/joomla/joomla-cms/pull/43164....

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Fixed @Hackwar

[5.2] Add the "none-ID" behavior to the CRON Scheduler

@richard67 I have just updated the texts, during the discussion here the code has been changed so the instructions needed to be updated too.

[5.2] Add the "none-ID" behavior to the CRON Scheduler

hmm will take a look into that. Its kind of an correct error when the ID does not exist, but as there is still the issue with the article id...

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Yes the main question is should we implement a check whether the passed ID is an valid task ID or should we issue an error like mentiond above. While the...

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Yes in that case the error is correct and this PR is ready and the test was ok :)

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Wasnt the plan to merge this into 5.2 still? @Hackwar ?