Yuvi

Results 1104 comments of Yuvi

Thank you for researching this thoroughly and opening this up, @consideRatio! I think when external URLs that can live anywhere (emails, course websites, etc) are counted, we should try *really...

Let's deprecate it (maybe a warning message if it is detected?) but leave it in?

@balajialg part of the problem is that the design guideline is to *never* have conflicts (https://jupyterhub.github.io/nbgitpuller/topic/automatic-merging.html), and when conflicts do happen it's already an error. And unfortunately the git error...

Could be helped by https://github.com/jupyterhub/nbgitpuller/pull/269

#269 will help with one set of merge conflict errors, but I suspect maybe the GSIs you spoke to were running into something else, @balajialg. But each error is different,...

@jdmansour the three levels you lay out seem great! Making sure all `CalledProcessErrors` provide readable output could also be a first start

Thanks for opening this, @cdbeon! It's a well written useful issue, so thank you for putting effort into it :) Do you have a link to the repo that's causing...

Awesome! @consideRatio how do we document this breaking change? CHANGELOG?

@consideRatio Agree on landing this for 1.0. But I think we should get #177 fixed before 1.0.

Yeah, I think the goal is to make sure some *minification* happens, so we don't load close to half a megabyte of JS on page load. We should also make...