nbgitpuller icon indicating copy to clipboard operation
nbgitpuller copied to clipboard

Optional command-line keyword arguments

Open sean-morris opened this issue 4 years ago • 5 comments

The optional command-line arguments(repo-dir and branch_name) are now keyword arguments; this allows us to avoid having to pass an empty branch_name(e.g. "") as the second argument if you want to pass in the repo_dir as the third argument. In the previous configuration, we used positional arguments(gitpuller git_url branch_name repo_dir) this change uses keyword arguments: gitpuller git_url --branch_name [BRANCH_NAME] --repo_dir [REPO_DIR]

resolves #187

sean-morris avatar Jun 24 '21 17:06 sean-morris

Awesome!

@consideRatio how do we document this breaking change? CHANGELOG?

yuvipanda avatar Jun 27 '21 12:06 yuvipanda

1.0.0 release and changelog? :)

consideRatio avatar Jun 27 '21 12:06 consideRatio

@consideRatio Agree on landing this for 1.0. But I think we should get #177 fixed before 1.0.

yuvipanda avatar Jun 27 '21 18:06 yuvipanda

I can document in the changelog but what version are we bumping? 1.0 and wait on this PR for #177 or 0.11 and merge this piece?

sean-morris avatar Jul 07 '21 19:07 sean-morris

I would love to see a fix to this master vs main in nbgitpuller

ericvd-ucb avatar Sep 04 '21 00:09 ericvd-ucb