Yuanyuan Zhao

Results 7 comments of Yuanyuan Zhao
trafficstars

FYI, this is blocked behind a Golang tracer issue on output json of the sampling rule: https://dd.slack.com/archives/CKXKHAKFG/p1709736745814879 A new test thus fails without a fix to that problem. This PR...

> @yuanyuanzhao3 hi there, have you looked into why the changes cause the increase in StartSpan time? Hi, I do not get a message that there was an increase in...

> I am referring to the BenchmarkStartSpan, it was previously reported by the benchmarking bot. I see that the message is now edited and is no longer a case(you can...

> Overall, looks good to me. Is there testing supplementing this code on the system-tests side? Yeah. Misha is getting someone from the Python team to do it.

I'm wondering why we need to have a `sampling_adjustment` flag, where the value can be false. It is not needed for cases where sampling probability is `100%`. In the case...

I also think that allowing conditioning the sampler choice won't work. I also thought about some composite adjusted count by combining the adjusted count on arrival and the sampling happen...

I think it will be helpful to consider a general case where there are 1. two parents, `P1` and `P2`, each sampling by a given percentage, `p1` and `p2`; 2....