Ygal Blum
Ygal Blum
> Should I merge with latest master to see if it fixes the failed test? > If yes, is the practice to merge or rebase? Yes. Just rebase on top...
@containers/podman-maintainers PTAL. This will probably affect the discussion #22496
> Letting quadlet generate one doesn't seem to useful to me. We can ship the static unit file in the rpm as I don't think there is anything dynamic needed...
@Luap99 great, thanks for the clarification. So, it seems that in terms of functionality the way to go is to add this service to the installation and add a dependency...
The specific code LGTM. But, it addresses only the `.image` files. Doesn't the same rational apply for `.container` and `.kube` files? In addition, while the documentation states that setting `After=`...
@jbtrystram how about `assert-last-key-is-regex` and pass `^$`?
Another two tests are failing since they already check the `After` key. The check `assert-key-is` expects all the values in the correct order. So you need to change the following:...
[test_fixes.txt](https://github.com/containers/podman/files/15399345/test_fixes.txt) @jbtrystram The tests fail because they were checking the values of the `After` key and this PR changes them (as it automatically adds `network-online.target`. I've attached a patch file...