Ygal Blum
Ygal Blum
> Pushed fixes and a typo in the mapping table. Let me know if you want me to squash the commits after the review. > > Btw I guess it...
The code looks good. Please make sure to add test(s)
> Thanks @ygalblum for the comment, I had updated my test. Great, thanks > On the other hand, for `actual restarting of an init container`, do you mean when sidecar...
I fear that merging this code without the code to restart the init-container might mislead the users as they will expect that the init-container is restarted while in fact in...
> According to https://github.com/containers/podman/blame/7dc7cbfd9b0440ddc86e210a2272fdaccd6376bb/pkg/domain/infra/abi/play.go#L803, the original init-container can not be restarted. So maybe we can just merge this PR with documentation? Fine by me. @containers/podman-maintainers Are you OK with this...
> Makes sense from my understanding of a pod, that an init container only happens once during creation of the pod. K8S is kinda piggybacking on init-containers to define side-car...
The LGTM. @vincentywdeng do you mind squashing the commits?
> Thanks, I squashed my commits. How can I proceed with the the PR? There are some failed tests which I belive is unrelated to my change. @vincentywdeng It seems...
The code LGTM and it seems like the test failures are unrelated.