Xavier del Castillo
Xavier del Castillo
Note, the intent of this feature request is to only provide basic filtering capabilities when looking at a queue in a particular state, although it would be nice to think...
Looks like a limitation on the `EventListenerMetadata` class when checking if the object is eligible to have callbacks applied to it: https://github.com/typeorm/typeorm/blob/1197f881382d5d7a1f604ab53ae34e9461bf1ffe/src/metadata/EntityListenerMetadata.ts#L61 Plain objects will not pass the validation with...
Nice proposal! It would also be useful to register children jobs depending on the state of the parent job, for example, if the job succeeded, then I want `jobB` and...
This patch is wrong. The last argument `mapAsEntity` will cause this line to evaluate to some `EntityMetadata` and enter the `if` block: https://github.com/typeorm/typeorm/blob/46249303be03adea74266837b8e6eb49227f476e/src/query-builder/SelectQueryBuilder.ts#L2038-L2039 That `if` block will ignore the `subQuery`...
Fixed on: https://github.com/typeorm/typeorm/pull/10769
@gioboa It's still be valid. The PR includes test coverage here: https://github.com/typeorm/typeorm/pull/10769/files#diff-fc1093be2aa4e9334350e29375146e0e2cc029295285b80c5caf92dac490c422 Open to comments if it's in need of more tests.
> @xdc0 Thanks for the contribution! 💜 > > The changes look good. Can you please rebase your branch onto latest master, so that we can run tests? will do
> @xdc0 could you check if [#5637 (comment)](https://github.com/typeorm/typeorm/issues/5637#issuecomment-3189859054) solves the original issue for you? @alumni Yes, it is still an issue when adding `subQuery()` to `qb`: ``` query builder >...
Updated fork with upstream. Updated test to use `subQuery`. Ready for another review pass.