Wim Selles

Results 211 comments of Wim Selles

Hi @Phonesis I didn't saw the previous response. The beta version already has the possibility to provide extra data as shown [here](https://github.com/wswebcreation/protractor-image-comparison/tree/feat/rewrite-to-ts-plugin#test-result-outputs)

When you do that you will get back an object, you need to compare it with 1 of the keys, like `misMatchPercentage` I'm not that fond of returning the base64...

Ahh, cool, tnx for the update.

@Nagadinesh Are the tests on your local machine and on the CI run on the same browser / OS combination? If not then that is the issue, each browser/os combination...

@cdlischynski If you upgrade to this version it should be working again, see https://github.com/wswebcreation/protractor-image-comparison/releases/tag/v3.3.1 ![github-chrome-latest-1366x768](https://user-images.githubusercontent.com/11979740/64678768-8f7ddd80-d47a-11e9-8150-9ce92e85943c.png)

Hi @tomyam1 Thanks for the investigation, can you maybe create a PR for it?

Hi @tomyam1 Thanks for the PR, do you also have a demo site where I can verify it, I will then check it on all devices I have and release...

Hmm, good one, never thought about this. Where would you like to put this, in the embeddings?

That would be possible, we only need to find a way to distinguish that `embeddings: [ { data: , mime_type: "text/plain", }, ],` is for a video tag instead of...