Wim Selles

Results 211 comments of Wim Selles

@amolinaalvarez Thanks for filling the issue, it's related to this one https://github.com/wswebcreation/webdriver-image-comparison/issues/21 Will come up with a fix asap

Hi @amolinaalvarez Ive release version `3.3.0` for `protractor-image-comparison, see [here](https://github.com/wswebcreation/protractor-image-comparison/releases/tag/v3.3.0). Can you please try that one and see if it is fixed? If so, can you close this issue?

@amolinaalvarez Thanks for you quick response, can you check 2 things for me 1. What version of the `webdriver-image-comparison` is stored in your `package-lock.json` file? 2. Can you share you...

~Hmm, let me check, I'll get back to it~ You are right, I see the problem. The problem is in the new `getDocumentScrollHeight` , see https://github.com/wswebcreation/webdriver-image-comparison/blob/master/lib/clientSideScripts/getDocumentScrollHeight.ts#L11 There were issues on...

Hi @tomyam1 It's always hard for a module to detect how the page works and what element should be the element that should be scrolled. Each page is different. What...

Wow, nice @ablok I've requested a small change on the PR. IS there maybe a way that you can add this also as a custom matcher? For and Jasmine/Mocha/Cucumber. That...

Hi @josefsmrz Thanks for this request, this seems to be a nice feature, but can get really messy with a lot of features / tests. Feel free to propose a...

@ganjarpanji Thanks for filing an issue, I've released a new version that should work now. Can you please check it? https://github.com/wswebcreation/start-ios-simulator/releases/tag/v1.0.0 If it works, can you please close the issue?...

~Hmm, looks like you try to run a simulator that is not installed on your machine, check XCODE and see if the OS version you requested is really installed on...

Thanks for this issue, I'll take a look at it when I have some more time