Wiktor Phillips

Results 21 comments of Wiktor Phillips

Might be fixed. I'll reopen if necessary.

Revised for a single issue. See edited remarks.

I've been looking at this. I'll leave a couple notes for possible correction/feedback from @YingboMa and/or to potentially help anyone else that attempts to fix this: The symbolics used by...

I still don't understand @YingboMa why this isn't an issue. The fact that they are "not the same" should be resolved by the declaration `x ~ sub.x` should it not?...

Gotcha. I managed to work around this by explicitly setting `sub.x => x` in the map of defaults used by `comp`. However, I also discovered that if I try to...

I kept it to just the julia target meethods. If you want to make it across all methods of `_build_function` let me know

The fix from @shashi solves the observable scoping issue. But when I tested it with some Conductor.jl models it returns solutions that are wrong if in `MultithreadedForm()` (serially executed sharded...

I noticed that this seems to crop up in other situations unrelated to just sharding. Basically anytime a nested RGF is built (see the code generated in https://github.com/SciML/ModelingToolkit.jl/issues/2173#issuecomment-1567090435 for a...

@YingboMa @shashi is there a hard requirement for `postprocess_fbody` to be a function on expressions for MTK models? Right now MTK defines constants and substitutions by using `SymbolicUtils.Code` types (e.g....