Wouter de Jong

Results 289 comments of Wouter de Jong

I don't think we should allow multiple documents to be routed to the same action. It seems very strange, each document should have a dedicated HTTP entry point imo (e.g....

Besides that this is PHPCR specific, I don't see what makes this different than the `path` and `url` functions provided by the TwigBridge? If it's only about the method name,...

> cmf paths are often editable by clients whereas normal symfony route names are not. Whether a name changes a lot (I'm not sure of that) or not, if it...

Removed the milestone. We have to further investigate and discuss how to implement this for routes. See the referenced PR for more information.

There are already quite some config tests: https://github.com/symfony-cmf/RoutingBundle/tree/master/Tests/Resources/Fixtures/config

@dbu looking at the coverage, I think we have covered it quite well: http://jsbin.com/sozimako/1/quiet

Hmm, most edge cases of the extension aren't covered: http://jsbin.com/sozimako/2/quiet

-1 on removing the configuration etc from the extension. Imo, the DIC driver should load the config from the DIC, not the config files. It'll be very hard to create...

Yeah, I tend to agree with @dbu Maybe having the other formats in here doesn't make much sense.

> In my opinion libraries should drop support of PHP versions that are end of life, because it makes contributing to this library much easier. I'm not sure about the...