Wouter de Jong

Results 289 comments of Wouter de Jong

Would removing `final` from `ProgressBar` fix your use-case without this attribute?

Can you please share what issue this function in the global namespace has caused for you? I would love to know the practical benefits of this change, rather than the...

> And again: there is just not any drawback to have your functions namespaced in any way except if you feel that importing a symbol is a pain (but in...

Good find! I'm not totally sure how to fix this. The problem is that the deprecation of `!tagged` in favor of `!tagged_iterator` was merged up from 4.4 into 5.0-dev *after*...

My 2-cents: What I liked about the original proposal in #47646 is the fact that we don't have to deprecate `$request->request`. We add a new property (name tbd), which covers...

Indeed, upon removing `symfony/messenger`, this file should be removed: https://github.com/cybernet/new_symfony_project/blob/main/config/packages/messenger.yaml If you remove `symfony/notifier`, you should remove the specific routing for notifier messages in the messenger configuration: https://github.com/cybernet/new_symfony_project/blob/main/config/packages/messenger.yaml#L20-L21 When starting...

Are you able to create a minimal reproducer application, that would help with debugging this. Btw, you mention slow performance in both local and production. The profiler, and traceable firewall...

I think we should keep this issue open, or at least close as completed. We have an open PR about this (#47938) that we should continue, we can do this...

> Does this work fine for commands accepting array arguments, where the number of accepted arguments is infinite ? Yes, the `$acceptedIndex += \count($argumentValue);` line should take care of that...

Marking this as WIP, the failing test in FrameworkBundle reveals some errors with this approach (we should only compare *argument tokens*, not all tokens as this includes options and option...