Price Withers
Price Withers
If I check condition number using np.linalg.cond(), how can I know whether it would be considered too large? In my sample data, when there is no common average reference the...
Submitted the PR. The dynamic model seems to work well. The residuals are quite small, even less than the OLS. I'm not sure if the average epochs model works as...
I agree that using only the l2_reg argument will make things much simpler. Do you want me to implement this and then commit the changes?
I opted to keep the underlying functions unchanged w/r/t the l2_reg parameter, but I had to overwrite the l2_reg value in line 185 to avoid problems. This isn't clean for...
I've never worked with unit tests before. What would be a good unit test to add for the new features and how do I add that? As for the current...
Thanks for the debugging help in the last comment! I was able to fix the problem where I did not account for the case when l2_reg='auto' and ``data`` is not...
OK, I tried my best to follow your suggestions. I only needed to set one eigenvalue to 1e-6 to obtain an ill-conditioned matrix (as long as there are 12 channels...
> Hey @witherscp just checking in on this to see if you need any assistance? > > If there is trouble figuring out a rigorous scenario where this is tested,...